Add support to configure tsh directory for data
#7035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add test coverage to this PR. |
fspmarshall
reviewed
Jun 3, 2021
There was a problem hiding this comment.
Looks like .tsh is always being appended to the custom path. Is there a specific reason for this? Seems unnecessary and potentially confusing to me. I think it would be better if we used the path specified by the user directly. Especially since .tsh is a hidden directory, meaning that users would likely believe that their custom path simply wasn't being set if no visible changes appear in their target directory.
|
@fspmarshall there was not a specific reason for it, I was just following the default, storing profiles in a hidden directory, but I can remove the appending of |
|
@quinqu Makes sense. Lets do that. I think it'll be more intuitive. |
fspmarshall
approved these changes
Jun 3, 2021
xacrimon
approved these changes
Jun 3, 2021
quinqu
force-pushed
the
jane/add-setting-tsh-home-dir
branch
from
958c9bb to
3c7093a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds support for configurable home location for
tshconfiguration and data.Implementation
Read in environment variable (if there is one) and store
tshdata in configured path.Fixes #3375